Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement the functionality of removeMembers #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rana718
Copy link

@Rana718 Rana718 commented Aug 24, 2024

This pull request implements the remove_members function for the Registry contract as outlined in Issue #6. The function has been adapted to use u256 instead of bytes32 and is designed to revoke the specified members' access from a profile.

Changes Made:

  • Implemented the remove_members function in Cairo.
  • Converted profile_Id from u256 to felt252 for compatibility.
  • Iterated through the members array to revoke their roles using self.accessControl._revoke_role.
  • Updated member_length with the length of the members array.

@Akashneelesh
Copy link
Collaborator

Hey @Rana718 could you do scarb fmt and also fix the error while trying to do snforge test

@Rana718
Copy link
Author

Rana718 commented Aug 28, 2024

Thanks for the feedback! I've just pushed the latest changes that include running scarb fmt to format the code. I also fixed the errors encountered during snforge test, and everything should be working smoothly now.

@Akashneelesh
Copy link
Collaborator

@Rana718 Still been getting the same error could you check on it ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants